Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't log the value of --password if given #458

Merged
merged 1 commit into from Oct 1, 2021

Conversation

imjasonh
Copy link
Member

@imjasonh imjasonh commented Oct 1, 2021

Found in #457

@codecov-commenter
Copy link

Codecov Report

Merging #458 (9a76a70) into main (688ca47) will decrease coverage by 0.14%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #458      +/-   ##
==========================================
- Coverage   53.25%   53.11%   -0.15%     
==========================================
  Files          36       36              
  Lines        1842     1847       +5     
==========================================
  Hits          981      981              
- Misses        710      715       +5     
  Partials      151      151              
Impacted Files Coverage Δ
pkg/commands/create.go 47.43% <0.00%> (-3.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 688ca47...9a76a70. Read the comment docs.

@imjasonh imjasonh merged commit b9cd759 into ko-build:main Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants