Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .ko.yaml to base ko container image on golang:1.17 #533

Merged
merged 2 commits into from
Dec 14, 2021

Conversation

imjasonh
Copy link
Member

$ img=$(ko build ./)
...
$ docker run --rm \
  --volume $(pwd):/src \
  --workdir /src \
  --volume ~/.docker:/root/.docker \
  -e KO_DOCKER_REPO=quay.io/imjasonh \
  ${img} \
  build ./ \
  --sbom=none
...
quay.io/imjasonh/ko-98b8c7facdad74510a7cae0cd368eb4e@sha256:7c4c064d8ca7880b4a98674201b2c5e7c6df7fb536b5f4a470acce1a9f75f14b

(Pushing to quay.io since I don't have it configured to use a cred helper, which makes demonstrating this more annoying -- this also exposed #532, which is why I'm testing with --sbom=none)

When we have the image pushed and tagged in the release we should add documentation for this usage in the README.

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2021

Codecov Report

Merging #533 (0d7648b) into main (2ba70fc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #533   +/-   ##
=======================================
  Coverage   48.16%   48.16%           
=======================================
  Files          42       42           
  Lines        2182     2182           
=======================================
  Hits         1051     1051           
  Misses        954      954           
  Partials      177      177           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ba70fc...0d7648b. Read the comment docs.

Ignore this in e2e tests, since even though golang:1.17 provides a
Windows base image, ko's base image platform selection doesn't take
osversion into account. The e2e tests don't exercise golang usage at
all, so it shouldn't matter.
@imjasonh imjasonh merged commit 96bedf1 into ko-build:main Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants