Filter out nil addendum before constructing index. #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the PR where we added concurrency we used a fixed length array to store addendum to preserve the ordering from the base image when constructing the final index. However, with `--platform=...` this list may be filtered, which gives us `nil` entries in our addendum. This filters `nil` entries prior to constructing the index. Fixes: ko-build#544
|
If you have opinions on where I can easily add test coverage for this, I'm happy to, but this fixes @imjasonh repro for me |
jonjohnsonjr
approved these changes
Dec 14, 2021
imjasonh
approved these changes
Dec 14, 2021
Adding something to e2e.yaml to just build a two-platform image would be fine by me. We don't even have to run it. |
|
Ok added something here: #547 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the PR where we added concurrency we used a fixed length array to store
addendum to preserve the ordering from the base image when constructing the
final index. However, with
--platform=...this list may be filtered, whichgives us
nilentries in our addendum.This filters
nilentries prior to constructing the index.Fixes: #544