Eliminate cred helper log spam #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
imjasonh
force-pushed
the
patch-ecr-helper
branch
2 times, most recently
from
4059872
to
c2ea76e
Compare
imjasonh
changed the title
|
The ecr-login PR has merged 🎉 This PR supercedes and includes the changes from #597 as it turns out |
|
Fixed by #599, I'll rebase |
imjasonh
force-pushed
the
patch-ecr-helper
branch
from
c2ea76e
to
05a7125
Compare
jonjohnsonjr
approved these changes
Feb 16, 2022
halvards
added a commit
to halvards/skaffold
that referenced
this pull request
Mar 15, 2022
Use a new logrus.Logger instance instead of the default logrus singleton. Relying on the default singleton is problematic when dependencies (or transitive dependencies) also use logrus. When code paths in these dependencies modify the default singleton, it also impacts Skaffold logging. I ran into this issue while trying to upgrade the `ko` dependency to v0.10, and there was unwanted error-level log output messages from `amazon-ecr-credential-helper`. Context: - ko-build/ko#586 - awslabs/amazon-ecr-credential-helper#309 This change also moves us closer to not leaking the logger implementation dependency outside the `output/log` package. Tracking: GoogleContainerTools#7131
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This picks up google/go-containerregistry#1284 to eliminate pkg/v1/google.Keychain spam, and awslabs/amazon-ecr-credential-helper#309 (not yet merged) to allow callers to eliminate ecr-login spam, which
konow does.