isError for a non-existing type returns false

[yigit]

Given the following java source:

                package foo.bar;
                public class Baz extends IDontExist {
                }

If I run:

resolver.requireClass("foo.bar.Baz").superTypes.first().resolve()?.isError

this returns false instead of true.
KSP version: 1.4.0-dev-experimental-20200914

[yigit]

similarly, for the following input:

public class Baz {
                    NotExistingType badField;
}

the type of badField's isError also returns false.

[neetopia]

#108 has a tentative fix to this.

[yigit]

i'm not sure if this is fixed, I'm still seeing the same error with the 20201120 version but CL got in on Oct 9 so should've been fixed?

This is my test input:

package foo.bar;
public class Baz {
    NotExistingType badField;
}

the type of badField returns false from isError.

[yigit]

actually i think this is happening because i internally call asMemberOf when resolving fields and I can observe that calling asMemberOf from an error type loses the isError property.
Seems like it is a different bug after all though.

Should we change asMemberOf to bail out immediately if type is an error type?

[neetopia]

fixed in #607