KLS: Deal more gracefully with zero-width definition spans. #2944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an indexer emits a zero-width span by providing a start location without an end, the language server will currently discard it because it lacks an end marker. While this is not an ideal way for the indexer to represent definitions, we can get a somewhat less surprising result by reusing the start location as the end when the latter wasn't provided.
danielmoy-google
approved these changes
Aug 18, 2018
creachadair
added a commit
that referenced
this pull request
Aug 20, 2018
) This is a follow-up to #2944. In addition to not throwing away empty spans from the service, also ensure that when those spans are not discarded when they don't get moved by remapping.
schroederc
pushed a commit
to schroederc/kythe
that referenced
this pull request
Nov 8, 2018
If an indexer emits a zero-width span by providing a start location without an end, the language server will currently discard it because it lacks an end marker. While this is not an ideal way for the indexer to represent definitions, we can get a somewhat less surprising result by reusing the start location as the end when the latter wasn't provided.
schroederc
pushed a commit
to schroederc/kythe
that referenced
this pull request
Nov 8, 2018
…the#2946) This is a follow-up to kythe#2944. In addition to not throwing away empty spans from the service, also ensure that when those spans are not discarded when they don't get moved by remapping.
schroederc
pushed a commit
to schroederc/kythe
that referenced
this pull request
Nov 8, 2018
If an indexer emits a zero-width span by providing a start location without an end, the language server will currently discard it because it lacks an end marker. While this is not an ideal way for the indexer to represent definitions, we can get a somewhat less surprising result by reusing the start location as the end when the latter wasn't provided.
schroederc
pushed a commit
to schroederc/kythe
that referenced
this pull request
Nov 8, 2018
…the#2946) This is a follow-up to kythe#2944. In addition to not throwing away empty spans from the service, also ensure that when those spans are not discarded when they don't get moved by remapping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an indexer emits a zero-width span by providing a start location without an
end, the language server will currently discard it because it lacks an end
marker. While this is not an ideal way for the indexer to represent
definitions, we can get a somewhat less surprising result by reusing the start
location as the end when the latter wasn't provided.