style: add standard scripts for git hooks #3174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initially, the `pre-commit` hook runs the legacy arcanist unit/lint commands (see kythe#3173) and the `commit-msg` hook runs `commitlint` to check for the Conventional Commit format. See http://go/gh/marionebl/commitlint#getting-started for the new `commitlint` tool dependency.
| google-java-format -n "$file" | sed 's/^/google-java-format::error:1 /' | ||
| fi ;; | ||
| *.go) | ||
| if command -v gofmt &>/dev/null; then |
There was a problem hiding this comment.
If they don't have the formatter installed, can we output a warning message instead of silently skipping the formatting step?
There was a problem hiding this comment.
We can do that per-file but not once per arc lint invocation.
salguarnieri
approved these changes
Oct 19, 2018
schroederc
added a commit
to schroederc/kythe
that referenced
this pull request
Nov 8, 2018
Initially, the `pre-commit` hook runs the legacy arcanist unit/lint commands (see kythe#3173) and the `commit-msg` hook runs `commitlint` to check for the Conventional Commit format. See http://go/gh/marionebl/commitlint#getting-started for the new `commitlint` tool dependency.
schroederc
added a commit
to schroederc/kythe
that referenced
this pull request
Nov 8, 2018
Initially, the `pre-commit` hook runs the legacy arcanist unit/lint commands (see kythe#3173) and the `commit-msg` hook runs `commitlint` to check for the Conventional Commit format. See http://go/gh/marionebl/commitlint#getting-started for the new `commitlint` tool dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially, the
pre-commithook runs the legacy arcanist unit/lintcommands (see #3173) and the
commit-msghook runscommitlinttocheck for the Conventional Commit format.
See http://go/gh/marionebl/commitlint#getting-started for the new
commitlinttool dependency.