Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leveldb shared library doesn't list snappy as a dependency. #100

Closed
cmumford opened this issue Sep 9, 2014 · 3 comments
Closed

leveldb shared library doesn't list snappy as a dependency. #100

cmumford opened this issue Sep 9, 2014 · 3 comments
Assignees

Comments

@cmumford
Copy link
Contributor

cmumford commented Sep 9, 2014

Original issue 94 created by jtolds on 2012-06-05T18:05:37.000Z:

What steps will reproduce the problem?

  1. from a fresh clone, make
  2. ldd libleveldb.so.1

What is the expected output? What do you see instead?
snappy should be listed, but it is not.

What version of the product are you using? On what operating system?
i'm using leveldb 1.5 on ubuntu 12.04

Please provide any additional information below.
the problem is that the '-lsnappy' option (from the generated build_config.mk's PLATFORM_LDFLAGS) is being provided before the list of source files. if it is provided after, then the dependency is properly listed in the generated so file.
This can be fixed by moving $(SOURCES) to be a sooner option in the $(SHARED3) target.

@cmumford
Copy link
Contributor Author

cmumford commented Sep 9, 2014

Comment #1 originally posted by carlopires on 2012-08-31T14:07:14.000Z:

This is critical to use shared leveldb with python ctypes (see http://code.google.com/p/leveldb-py/) so, please fix this. I attached a patch.

@cmumford cmumford self-assigned this Sep 9, 2014
@cmumford
Copy link
Contributor Author

cmumford commented Sep 9, 2014

Comment #2 originally posted by jtolds on 2012-08-31T16:05:02.000Z:

For anyone waiting on this issue, I have a fork of LevelDB that both fixes this and adds Debian packaging: http://code.google.com/r/jtolds-leveldb/

@cmumford
Copy link
Contributor Author

cmumford commented Sep 9, 2014

Comment #3 originally posted by sanjay@google.com on 2012-10-12T19:58:50.000Z:

Fixed in 1.6.0.

@cmumford cmumford closed this as completed Sep 9, 2014
maochongxin pushed a commit to maochongxin/leveldb that referenced this issue Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant