Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix comment #457

Merged
merged 2 commits into from May 9, 2019
Merged

fix comment #457

merged 2 commits into from May 9, 2019

Conversation

jellor
Copy link

@jellor jellor commented Mar 10, 2017

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@jellor
Copy link
Author

jellor commented Mar 10, 2017

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@cmumford
Copy link
Contributor

@googlebot rescan

@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@cmumford
Copy link
Contributor

@jellor sorry for the delay. Can you resolve the conflict so that I can merge your PR?

@cmumford
Copy link
Contributor

cmumford commented May 5, 2019

Thx for the PR @jellor. If you can resolve the merge conflict I'll be happy to merge this.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@cmumford cmumford merged commit 1d94fe2 into google:master May 9, 2019
cmumford added a commit that referenced this pull request May 9, 2019
PiperOrigin-RevId: 247261470
maochongxin pushed a commit to maochongxin/leveldb that referenced this pull request Jul 21, 2022
Triggered by -Werror=double-promotion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants