Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Prevent LOG handle from being inherited by subprocesses #941

Merged
merged 1 commit into from Nov 30, 2021

Conversation

dktapps
Copy link
Contributor

@dktapps dktapps commented Oct 9, 2021

I recently encountered a problem with this because Windows doesn't allow
files to be deleted when there's open handles to them.

Other files opened by leveldb are not affected because by and large they
are using CreateFileA, which does not allow inheritance when
lpSecurityAttributes is null (ref:
https://docs.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilea)

However, fopen() does allow inheritance, and it needs to be expressly
disabled.
https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/fopen-wfopen?view=msvc-160

@google-cla
Copy link

google-cla bot commented Oct 9, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Oct 9, 2021
@dktapps
Copy link
Contributor Author

dktapps commented Oct 9, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Oct 9, 2021
@dktapps dktapps changed the title Explicitly disallow handle inheritance on Windows Explicitly disallow handle inheritance on Windows + fix LOG being inherited by subprocesses Oct 9, 2021
@dktapps dktapps changed the title Explicitly disallow handle inheritance on Windows + fix LOG being inherited by subprocesses Explicitly disallow handle inheritance on Windows + fix LOG handle being inherited by subprocesses Oct 9, 2021
I recently encountered a problem with this because Windows doesn't allow
files to be deleted when there's open handles to them.

Other files opened by leveldb are not affected because by and large they
are using CreateFileA, which does not allow inheritance when
lpSecurityAttributes is null (ref:
https://docs.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilea)

However, fopen() _does_ allow inheritance, and it needs to be expressly
disabled.
https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/fopen-wfopen?view=msvc-160
@dktapps dktapps changed the title Explicitly disallow handle inheritance on Windows + fix LOG handle being inherited by subprocesses Windows: Prevent LOG handle from being inherited by subprocesses Oct 9, 2021
Copy link
Member

@pwnall pwnall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution!

"N" is not standardized (POSIX, C2011, etc.) but it is documented in MSDN: https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/fopen-wfopen?view=msvc-170 -- I think this is sufficient for Windows-specific code.

This PR will get imported in our internal repository, and then a bot will merge it here.

@pwnall pwnall self-assigned this Nov 29, 2021
@pwnall pwnall merged commit e426c83 into google:master Nov 30, 2021
@dktapps
Copy link
Contributor Author

dktapps commented Nov 30, 2021

Awesome, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants