Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dealing with countries that use only one address line #61

Closed
bojanz opened this issue Dec 19, 2014 · 1 comment
Closed

Dealing with countries that use only one address line #61

bojanz opened this issue Dec 19, 2014 · 1 comment
Labels
wontfix

Comments

@bojanz
Copy link

bojanz commented Dec 19, 2014

I've received reports from users in several countries* that the second address line is not used in their countries. And indeed, going to the sites of the AU & NZ post offices, only one line is rendered.

Was there ever a plan to split the %A token in the dataset into multiple tokens (one per address line)? I'm not sure how feasible such a thing would be (from a data gathering perspective, especially), but it's worth a discussion.

  • Australia, Estonia, Latvia, Lithuania, New Zealand, Russia, Finland
bojanz added a commit to commerceguys/addressing that referenced this issue Mar 2, 2015
@bojanz
Refactor format fields.
f6a7450 
- AddressField values are now camelCase, and map directly to address properties.
  This removes the need to have mappings in other classes.
- The address field %address has been split into %addressLine1 and %addressLine2.
  Allows formats to remove the second line, partially addressing
  google/libaddressinput#61
- Removed the dataset change listings, since all address formats have changed.
bojanz added a commit to commerceguys/addressing that referenced this issue Mar 2, 2015
@bojanz
Refactor format fields.
850c2aa 
- AddressField values are now camelCase, and map directly to address properties.
  This removes the need to have mappings in other classes.
- The address field %address has been split into %addressLine1 and %addressLine2.
  Allows formats to remove the second line, partially addressing
  google/libaddressinput#61
- Removed the dataset change listings, since all address formats have changed.
@bojanz bojanz mentioned this issue Dec 19, 2016
Open
@sockix
Copy link
Contributor

sockix commented Mar 29, 2018

There are no plans to break the %A token up.

AFAIK, there was a point in time when we use to show line 1 and line 2 as separate tokens, but have since gone away from that... so I highly doubt we'll break them up again.

@sockix sockix added the wontfix label Mar 29, 2018
@sockix sockix closed this as completed Mar 29, 2018
@bojanz bojanz mentioned this issue Oct 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bojanz @sockix