common: Fix symbol export using MSVC

[asoulier]

No description provided.

[amyspark]

Just a small nit (for reasons of consistency under Windows), otherwise LGTM.

[amyspark]

There's a further nit I had not noticed @asoulier, as regards importing shared v. static libraries.

• For shared libraries, you need to mark all the declarations in lc3.h et al. as __declspec(dllimport) for downstream consumers, otherwise MSVC will complain about __imp_ pivot symbols not found.
• For static libraries, you need to turn off the macro altogether.

Those could be tackled at once with a combination of defines for the shared build (-DDLL_EXPORTS, for instance?) and for the build process itself (-DSTATIC_BUILD in c_static_args with Meson >= 1.3.0, otherwise you may need to reject get_option('default_library') == 'both').

[amyspark]

The bit in #49 (comment) as regards static libraries on Windows still needs addressing.

[asoulier]

@amyspark I have added a CI to check compilation with MSVC.
Do you confirms that runs now correctly with MSVC ?

Thanks.

[amyspark]

@asoulier I think the only bit missing is the ability to build liblc3 statically too. Currently we'd need to hardcode the --buildtype flag or use MinGW to sidestep this issue.

[asoulier]

I changed the buildtype to release (It looks like it was compiling in debug by default).
I would not change the behavior of compiling dynamic library by default.
If I set the both option, the static library becomes installed on linux systems (Looks not useful for me).
If you want to generate both, can you have a try with:

meson setup --wipe --default-library both build

This works for me on linux.

[amyspark]

I tested again and MSVC 17.10 Preview 2, GCC 13.2 Rev 5 (MSYS2 UCRT64) and Clang 17 (CLANG64) are all happy.

[joakim-tjernlund]

i wonder if LC3_EXPORT could be moved to the src functions rather than a header which is public?

[asoulier]

MSVC needs a match between functions declaration and definitions.
So the header declarations needs to be decorated with __declspec(dllexport).

[joakim-tjernlund]

I see, thanks

[asoulier]

@amyspark Thanks for your checks!