Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isRegionUsingNationalPrefix #2625

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Anrufliste
Copy link

Reducing the publication of metadata for a region code of #2583 by just gaining access to its method hasNationalPrefix as an own method for a given RegionCode.

This method is directly used in the existing method getLengthOfGeographicalAreaCode where the beginning code is exactly the code needed for this functionality and thus can be replaced by it.

@google-cla
Copy link

google-cla bot commented May 30, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no For Google internal commits only label May 30, 2021
@Anrufliste
Copy link
Author

@googlebot I fixed it.

@google-cla
Copy link

google-cla bot commented May 30, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@Anrufliste
Copy link
Author

@googlebot I fixed it.

@google-cla google-cla bot added cla: yes For CLA bot and removed cla: no For Google internal commits only labels May 30, 2021
@Anrufliste
Copy link
Author

Hi, I think this is still a valid improvement and can be the base for some other improvements like https://issuetracker.google.com/issues/180311606 - can someone of the maintainer give me a feedback how the team see this pr? Thanks and Regards, Emil

@Anrufliste Anrufliste requested a review from a team as a code owner October 13, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes For CLA bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant