add option to disable unit tests

[cristeab]

No description provided.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[cristeab]

@googlebot I signed it!

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[penmetsaa]

Is this variable name change specific to your setup?

[penmetsaa]

Could you please revert to old variable name?

[cristeab]

CMAKE_CURRENT_SOURCE_DIR is cmake specific and must be used in this context as it correctly specifies the current folder of the existing cmake file. CMAKE_SOURCE_DIR represents the current folder of the top level cmake file.

[penmetsaa]

Hi,

Thanks for using libphonenumber and willing to contribute to the library.

Why do you want to have such an option? As we have not heared from others asking for this, we would like to know so that it helps in our review and get back to you ASAP. As there is no CPP expert (even for reviewing changes) within team, we are not actively adding features to build system unless absolutely necessary.

Some more feedback after my first look:

• Could you please let me know why the protocol buffer files of JS are updated. If these are updated because of build and not related to your changes, please revert them.
• Recieved below make error after pulling the edits. Am I missing anything here?
  [ 48%] Linking CXX static library libphonenumber.a
  [ 53%] Built target phonenumber
  Scanning dependencies of target geocoding_test_program
  [ 54%] Building CXX object CMakeFiles/geocoding_test_program.dir/test/phonenumbers/geocoding/geocoding_test_program.cc.o
  [ 55%] Linking CXX executable geocoding_test_program
  /usr/bin/ld: libphonenumber.a(phonenumberutil.cc.o): undefined reference to symbol 'pthread_once@@GLIBC_2.2.5'
  /usr/bin/ld: /lib/x86_64-linux-gnu/libpthread.so.0: error adding symbols: DSO missing from command line
  collect2: error: ld returned 1 exit status
  make[2]: *** [CMakeFiles/geocoding_test_program.dir/build.make:89: geocoding_test_program] Error 1
  make[1]: *** [CMakeFiles/Makefile2:188: CMakeFiles/geocoding_test_program.dir/all] Error 2
  make: *** [Makefile:152: all] Error 2
• I have followed instructions of "Building and testing the library" at https://github.com/google/libphonenumber/tree/master/cpp

[penmetsaa]

Could you please revert to old variable name?

[penmetsaa]

Why this?
If something is specific to your build, and may not be applicable or beneficiary for all, we can avoid that.

[cristeab]

geocoder is a binary for generating geo coding data. For cross-compilation builds, like Android, the binary should not be generated as it will not be run on Android. ANDROID variable comes from the toolchain cmake file provided within Android NDK.

[cristeab]

These changes are needed in order to allow libphonenumber to be integrated as subproject within another project using cmake and also to be able to cross-compile this library.

[cristeab]

The compilation errors you are seeing are likely linked to your environment. Try to use instead a Docker container. On my side I have compiled only on macOS

[penmetsaa]

As for common interest this should be by default "ON".

[cristeab]

fixed

[penmetsaa]

Hi,

As you might have understood by now, I am not familiar with CPP
Will try finding a CPP reviewer who has the context and expertise in build mechanics.
Thanks so much for your patience.

[silviucpp]

Any news related to this issue ? It's annoying that we are not capable to stop building unittests . In 99 % of the cases you don't need them. The only thing you need is the library to link with.