Fix NullPointerException when ShortNumberInfo.isPossibleShortNumber is used with a region not in ShortNumberMetadata

[giggsey]

Example code:

import com.google.i18n.phonenumbers.*;
import com.google.i18n.phonenumbers.Phonenumber.PhoneNumber;

public class Test {

    /**
     * @param args
     */
    public static void main(String[] args) {
        PhoneNumber phoneNumber = null;
        PhoneNumberUtil phoneNumberUtil = PhoneNumberUtil.getInstance();
        phoneNumber = phoneNumberUtil.getExampleNumber("NE");

        ShortNumberInfo shortNumberInfo = ShortNumberInfo.getInstance();

        shortNumberInfo.isPossibleShortNumber(phoneNumber);

    }

}

NE is a valid region, and exists in PhoneNumberMetadata. This means that the check in getRegionCodesForCountryCode returns the correct region code.

It then loops through, loading the metadata for each region, but doesn't actually check whether the metadata exists.

Credit to @RuslanGetmansky via giggsey/libphonenumber-for-php#68

I haven't updated any unit tests for this, but I can do if needed (my Java is not very good)

[dlyongemallo]

Thanks for reporting this, it'll be fixed in the next release.

[andyst]

Thanks! This is in libphonenumber 7.0.7.

[giggsey]

Is it?

ShortnumberInfo.java hasn't changed since Dec 2014.

[andyst]

Thanks! Looks like we didn't make the change on github yet. Reopening.

[giggsey]

I can see this has been fixed by #731, closing this one.