Add flag for tests building #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kitsu <mail@kitsu.me>
vitalybuka
requested changes
Sep 26, 2018
CMakeLists.txt
Outdated
| include(googletest) | ||
| if (TESTING) | ||
| enable_testing() | ||
| find_package(GTest) |
There was a problem hiding this comment.
Could you please remove find_package(GTest), it's unrelated to the patch
also this lib needs relatively new gtest, so installed version may not work
Signed-off-by: Kitsu <mail@kitsu.me>
|
Could you please rebase? |
vitalybuka
added a commit
to vitalybuka/libprotobuf-mutator
that referenced
this pull request
Oct 31, 2018
vitalybuka
added a commit
to vitalybuka/libprotobuf-mutator
that referenced
this pull request
Oct 31, 2018
Closed
vitalybuka
added a commit
that referenced
this pull request
Oct 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TESTINGoption can enable/disable builds of test so the project can be used as a library without redundant compilationsAlso I've add
find_package(GTest)line (maybe even delete cmake/external/googletest.cmake?), without it I cannot build:No rule to make target 'external.googletest/lib/libgtest.a', needed by 'src/mutator_test'. Stop.