debian package build #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuizumi
suggested changes
Sep 13, 2019
yuizumi
reviewed
Sep 13, 2019
yuizumi
reviewed
Sep 18, 2019
kumagi
force-pushed
the
feature/deb-packaging
branch
from
f086164
to
dee8b3c
Compare
yuizumi
reviewed
Sep 19, 2019
packaging/build_deb
Outdated
|
|
||
| cp "../${TARGET_NAME}_${VERSION}_${ARCHITECTURE}.deb" "${SRCDIR}" | ||
| cp ../*.deb \ | ||
| "${SRCDIR}/${TARGET_DIR}/${TARGET_NAME}_${VERSION}_${ARCH}_${RELEASE}.deb" |
There was a problem hiding this comment.
Why do you need to rename the package?
Well, whatever the reason is, this is really a bad idea. The Debian packaging has the naming convention all packages should obey: {NAME}_{VER}-{REL}_{ARCH}.deb; VER is the upstream version, REL is the Debian release number, ARCH is the architecture.
https://www.debian.org/doc/manuals/debian-faq/ch-pkg_basics#s-pkgname
There was a problem hiding this comment.
OK, Debian version will be contained by directory name.
packaging/debian/README.Debian
Outdated
| Signed HTTP Exchange library | ||
| ----------------- | ||
|
|
||
| Signed HTTP Exchange(SXG) is file format which contains an HTTP exchange |
There was a problem hiding this comment.
Done. /README.md too.
kumagi
commented
Sep 20, 2019
packaging/build_deb
Outdated
|
|
||
| cp "../${TARGET_NAME}_${VERSION}_${ARCHITECTURE}.deb" "${SRCDIR}" | ||
| cp ../*.deb \ | ||
| "${SRCDIR}/${TARGET_DIR}/${TARGET_NAME}_${VERSION}_${ARCH}_${RELEASE}.deb" |
There was a problem hiding this comment.
OK, Debian version will be contained by directory name.
packaging/debian/README.Debian
Outdated
| Signed HTTP Exchange library | ||
| ----------------- | ||
|
|
||
| Signed HTTP Exchange(SXG) is file format which contains an HTTP exchange |
There was a problem hiding this comment.
Done. /README.md too.
yuizumi
reviewed
Sep 20, 2019
yuizumi
reviewed
Sep 20, 2019
yuizumi
approved these changes
Sep 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.