Support gamma from users' input in the demo app #181
Conversation
| @@ -372,6 +374,7 @@ class UltraHdrAppInput { | |||
| size_t mMapDimensionScaleFactor; | |||
| int mMapCompressQuality; | |||
| bool mUseMultiChannelGainMap; | |||
| float mGamma; | |||
There was a problem hiding this comment.
const float mGainMapGamma;
this keeps in sync with other constructor arg declarations
| @@ -137,7 +136,7 @@ class JpegR { | |||
| public: | |||
| JpegR(); | |||
|
|
|||
| JpegR(size_t, int, bool); | |||
| JpegR(size_t, int, bool, float); | |||
There was a problem hiding this comment.
all constructors can be merged with
JpegR(size_t mapDimensionScaleFactor = kMapDimensionScaleFactorDefault,
int mapCompressQuality = kMapCompressQualityDefault,
bool useMultiChannelGainMap = kUseMultiChannelGainMapDefault,
float gainMapGamma = kGainMapGammaDefault);
| @@ -332,6 +331,12 @@ class JpegR { | |||
|
|
|||
| bool isUsingMultiChannelGainMap() { return this->mUseMultiChannelGainMap; } | |||
|
|
|||
| void setGainMapGamma(float gamma) { | |||
There was a problem hiding this comment.
are these getter setter functions required, as these are only controlled from constructor
There was a problem hiding this comment.
I think yes. User may change the configurations on the fly since we don't have a m_sailed-like flag at jpegr.cpp layer.
Besides, it's not convenient to set this parameters only from constructor. E.g. if user only wants to set gamma while use the default values for the other parameters, they'll need to also provide the other parameter values in the constructor.
| snprintf(status.detail, sizeof status.detail, "received nullptr for uhdr codec instance"); | ||
| return status; | ||
| } | ||
|
|
There was a problem hiding this comment.
error checks for gamma range are required.
check required if context has moved to running state from init (m_sailed).
No description provided.