Fixed compiling ARM64 target for Windows #186
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harishdm
approved these changes
Jul 1, 2024
ram-mohan
reviewed
Jul 2, 2024
lib/src/dsp/arm/gainmapmath_neon.cpp
Outdated
| @@ -19,6 +19,12 @@ | |||
| #include <arm_neon.h> | |||
| #include <cassert> | |||
|
|
|||
| #if _WIN32 | |||
There was a problem hiding this comment.
should this be
#ifdef _MSC_VER
There was a problem hiding this comment.
Changed in newest commit
MajorMurphy
force-pushed
the
Windows-ARM64
branch
from
3bafe7c
to
261e832
Compare
harishdm
approved these changes
Jul 4, 2024
ram-mohan
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two issues:
__attribute__keyword not supported by MSVCwidthvariable instead ofw