-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
licenses: modifications to Apache-2.0 #37
base: main
Are you sure you want to change the base?
Conversation
Relax the Apache-2.0 LRE, based on licenses observed in the wild. - Accept some mis-numbered or mis-lettered headings. - Accept various word substitutions (e.g. "the" for "this"; "token" for "communication"). - Accept some MIT fragments at the end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few initial reactions. But the main thing is that there need to be test cases for these in testdata/.
That's also the place to put the URLs of where the oddities came from, not the LRE file itself.
licenses/Apache-2.0.lre
Outdated
|
||
"Licensor" shall mean the copyright owner or entity authorized by the | ||
(("Licensor" || "Restream")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not wild about hard-coding what I assume is a company name here (Restream).
Perhaps this should be just 1. ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
licenses/Apache-2.0.lre
Outdated
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
))?? | ||
|
||
)) | ||
|
||
//** from github.com/jsccast/rocksdb@v0.0.0-20150219174706-b65d32cc6e76/LICENSE **// |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe this is appropriate - this is really a second, separate license that should be recognized separately. I suggest adding to MIT.lre:
{{define "MIT-NoDisclaimer.lre"}}
{{template "mit-grant"}}
{{template "mit-conditions"}}
{{end}}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed.
licenses/Apache-2.0.lre
Outdated
@@ -3,6 +3,11 @@ Apache License 2.0 | |||
https://spdx.org/licenses/Apache-2.0.json | |||
http://www.apache.org/licenses/LICENSE-2.0 | |||
https://opensource.org/licenses/Apache-2.0 | |||
|
|||
exceptions: | |||
(( i || properties )) https://github.com/apache/rocketmq-client-go/issues/590 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that they've fixed this, can we drop this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not until they tag a new release. Their latest is still v2.0.0, which has "properties".
If you're uncomfortable adding it here I can keep it as an exception.
copyright owner that is granting the License. | ||
|
||
"Legal Entity" shall mean the union of the acting entity and all other | ||
entities that control, are controlled by, or are under common control with | ||
that entity. For the purposes of this definition, "control" means (i) the | ||
that entity. For the purposes of __1__ definition, "control" means ( | ||
(( i || properties || k )) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Who has "k"?
It's pretty weird to have (k), (ii), (iii).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
representatives, including but not limited to communication on | ||
purposes of __1__ definition, "submitted" means any form of electronic, | ||
verbal, or written | ||
((communication || token)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Who has token?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/arsham/retry/blob/master/LICENSE#L54
https://github.com/blokur/harego/blob/master/LICENSE#L54
and other modules by those users.
patent license to make, have made, use, offer to sell, sell, import, and | ||
otherwise transfer the Work, where such license applies only to those patent | ||
claims licensable by such Contributor that are necessarily infringed by their | ||
Contribution(s) alone or by combination of their Contribution(s) with the | ||
Work to which such Contribution(s) was submitted. If You institute patent | ||
litigation against any entity (including a cross-claim or counterclaim in a | ||
lawsuit) alleging that the Work or a Contribution incorporated within the | ||
((lawsuit || luit)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this an AWS remover? :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most likely! I found a bunch of search-and-replace artifacts, like "rebundleion" ("reproduction" with s/product/bundle/)
Relax the Apache-2.0 LRE, based on licenses observed in the wild.
Accept some mis-numbered or mis-lettered headings.
Accept various word substitutions (e.g. "the" for "this"; "token"
for "communication").
Accept some MIT fragments at the end.