Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
This adds basic coverage to license check to discover the BUSL as described by HASHICORP. I think the LRE can be written a bit more generically so we can capture the parameters and have a higher confidence match, but this is a first pass. We also have the option of adding a URL discovery option as well which I'm looking into.
The test case for this was awkward to write since the README specified that a test case could have the header:
When I included the second percent which I assumed was a percent coverage for the offset the test would error and show that it only expected:
BSD 1234,4567 [URL]
as a valid case entry.If this is incorrect and there is some other configuration where I can test the
%coverage
of the whole case along withthe%coverage
of the offset I would like to set it up that way.