Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add stub for BUSL-1.1 #65

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

spiffcs
Copy link

@spiffcs spiffcs commented Jan 29, 2024

Notes

This adds basic coverage to license check to discover the BUSL as described by HASHICORP. I think the LRE can be written a bit more generically so we can capture the parameters and have a higher confidence match, but this is a first pass. We also have the option of adding a URL discovery option as well which I'm looking into.

The test case for this was awkward to write since the README specified that a test case could have the header:

90.5%
BSD 98.9% 1234,4567 [URL]

When I included the second percent which I assumed was a percent coverage for the offset the test would error and show that it only expected: BSD 1234,4567 [URL] as a valid case entry.

If this is incorrect and there is some other configuration where I can test the %coverage of the whole case along withthe %coverage of the offset I would like to set it up that way.

Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
@@ -0,0 +1,95 @@
50.8%
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to get this percentage up before merging. This was the base case where I could get the LRE matching on everything under the hashicorp parameters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant