Cleanup buildifer formatting and lint warnings.
#84
Conversation
These aren't all trivial -- several of these showed questionable globs that I've tried to fix in the way that seemed most effective.
| @@ -2,6 +2,7 @@ | |||
| # See https://llvm.org/LICENSE.txt for license information. | |||
| # SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | |||
|
|
|||
| load("@rules_cc//cc:defs.bzl", "cc_binary", "cc_library") | |||
There was a problem hiding this comment.
Don't we need to add rules_cc to the workspace for this to work? https://github.com/bazelbuild/rules_cc#getting-started
It's not clear to me whether migrating to rules_cc is actually recommended right now. Internally I think we still use the native rules.
There was a problem hiding this comment.
This works for me without anything else.
And buildifier has a lint complaint w/o it that this fixes. So for example, without this, VSCode thinks that all of our uses of the native rules are issues. It highlights them, etc etc.
I don't see how this can not be recommended with the buildifier tool linting it for the last several months?
There was a problem hiding this comment.
Yeah I am also confused. I've filed bazelbuild/rules_cc#92 about the documentation/tooling mismatch
There was a problem hiding this comment.
Is there any harm in landing this to silence the lint warnings in the interim?
There was a problem hiding this comment.
I have no idea :-D There's at least some indication that the future of rules_cc is unclear and not well documented: bazelbuild/rules_cc#86. I'm a bit hesitant to move to it, given that
These aren't all trivial -- several of these showed questionable globs
that I've tried to fix in the way that seemed most effective.
This change is