This repository has been archived by the owner on Jun 30, 2023. It is now read-only.
jar: iterate over zip file headers instead of using fs.WalkDir #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid some of the edge cases we've hit when combining archive/zip and fs.WalkDir and iterate over the ZIP files directly. Lets us drop some workarounds. Negative is that we have to break a public API, but hopefully that's okay while we're pre v1.0.0. PR attempts to make the diff as small as possible.
twitchy-jsonp
approved these changes
Dec 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid some of the edge cases we've hit when combining archive/zip and
fs.WalkDir and iterate over the ZIP files directly. Lets us drop some
workarounds.
Negative is that we have to break a public API, but hopefully that's
okay while we're pre v1.0.0.
PR attempts to make the diff as small as possible.
#12
golang/go#50390
golang/go#50179