Skip to content
This repository has been archived by the owner on Jun 30, 2023. It is now read-only.

Report CVEs identified #60

Merged
merged 1 commit into from May 10, 2022
Merged

Report CVEs identified #60

merged 1 commit into from May 10, 2022

Conversation

singlethink
Copy link
Contributor

Updates jar.Parse to return the specific CVEs identified during the
scan.

To ensure that refactoring of detection logic is correct, I've tested
this on a corpus of all log4j2 releases through 2.16.0 and verified
that there are no false positives or false negatives.

jar/jar.go Show resolved Hide resolved
jar/jar_test.go Outdated Show resolved Hide resolved
Copy link

@junjiey1988 junjiey1988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM with one question and a minor nit.

Updates jar.Parse to return the specific CVEs identified during the
scan.

To ensure that refactoring of detection logic is correct, I've tested
this on a corpus of all log4j2 releases through 2.16.0 and verified
that there are no false positives or false negatives.
Copy link

@junjiey1988 junjiey1988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Matt!

@ericchiang ericchiang merged commit 48dbe0d into google:main May 10, 2022
@singlethink singlethink deleted the report-cves branch May 10, 2022 21:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants