Rewrite core proxy, TLS MITM support, and refactor all the things. #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ) | ||
|
|
||
| var ( | ||
| addr = flag.String("addr", ":8080", "host:port of the proxy") | ||
| apiAddr = flag.String("api-addr", ":0", "host:port of the configuration API") | ||
| apiHostname = flag.String("api-hostname", "martian.proxy", "hostname forwarded to apiAddr") | ||
| generateCert = flag.Bool("generate-cert", false, "generate certificate and private key for MITM") |
There was a problem hiding this comment.
add "CA" to message and we should document the use case
added 3 commits
July 30, 2015 13:51
| // TODO: Avoid creating real connection, spin up TLS server with fake | ||
| // certificate signed by generated CA. | ||
| // | ||
| // GET /humans.text HTTP/1.1 |
added 6 commits
July 30, 2015 20:52
strings rather than regexes.
| @@ -110,30 +96,44 @@ func (f *Filter) ResponseModifier(id string) martian.ResponseModifier { | |||
|
|
|||
| // ModifyRequest runs the RequestModifier for the associated ctx.Auth.ID. If no | |||
There was a problem hiding this comment.
update comment - no longer ctx.Auth.ID, it's actx.ID()
| func (f *Filter) ModifyResponse(ctx *martian.Context, res *http.Response) error { | ||
| if resmod := f.resmods[ctx.Auth.ID]; resmod != nil { | ||
| return resmod.ModifyResponse(ctx, res) | ||
| func (f *Filter) ModifyResponse(res *http.Response) error { |
There was a problem hiding this comment.
update comment - no longer ctx.Auth.ID, it's actx.ID()
admtnnr
added a commit
that referenced
this pull request
Jul 31, 2015
Rewrite core proxy, TLS MITM support, and refactor all the things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things we should have: