Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring to avoid flag definition clash #336

Merged
merged 5 commits into from Aug 16, 2022

Conversation

phaus
Copy link
Contributor

@phaus phaus commented Mar 21, 2022

should fix #335 335

@tomasbanet
Copy link

Hey. Any updates on this PR? Running into this issue while trying to use https://pkg.go.dev/cloud.google.com/go@v0.103.0/httpreplay (issue at googleapis/google-cloud-go#6501). So far my work-around consists of changing the Init function to:

// Init runs common initialization code for a martian proxy.
func Init() {
	level := flag.Int("v", 0, "log level")
	flag.Parse()
	mlog.SetLevel(*level)
}

@chrisivens
Copy link

Does this really need to bump to golang v1.18? Can it perhaps only go as far as v1.17? Some packages aren't yet ported to 1.18 fully yet.

@bramhaghosh bramhaghosh merged commit 0f7e679 into google:master Aug 16, 2022
@thenakulchawla
Copy link

Since this change is merged, will a new tag get created so we can pull the right version in? Thanks.

hubot pushed a commit to google/skia-buildbot that referenced this pull request Apr 16, 2024
This fixed this: google/martian#336

Change-Id: I5d83628918e140ecf2136f289603371038ad5aa5
Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/841450
Commit-Queue: Hao Wu <haowoo@google.com>
Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
Commit-Queue: Leandro Lovisolo <lovisolo@google.com>
Auto-Submit: Hao Wu <haowoo@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

removing flag parsing from module init
5 participants