Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the codepoints file #828

Closed
wants to merge 1 commit into from
Closed

Updated the codepoints file #828

wants to merge 1 commit into from

Conversation

ijlee2
Copy link

@ijlee2 ijlee2 commented Jul 21, 2018

Hello. I noticed that the codepoints file is outdated (also noted in #821, #813, #786, #785, #774, #766, #531). Personally, I need to know the Unicode values to render Material icons in D3, and would like to see this file updated.

I found most of the missing codepoints by (1) iterating all combinations and rendering them. For icons that are missing from the documentation, I was able to (2) guess some of the key names based on existing patterns.

As proof, you can find all icons in https://material-icons.herokuapp.com/. (1) Orange border means the icon has been newly added, (2) green, the icon is missing from the documentation, and (3) transparent, I don't know the key name yet.

Here are the code values whose key name I don't know. I'd like your help in finding them.

  • e179
  • e1ff
  • e93c
  • e93d
  • e94b
  • e94d
  • e94e

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@ijlee2
Copy link
Author

ijlee2 commented Jul 21, 2018

I've signed the CLA, thanks.

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@timoxley
Copy link

I note the battery_20, battery_30 etc codepoints are still missing, perhaps those are what you're looking for.

@ijlee2
Copy link
Author

ijlee2 commented Jul 28, 2018

@timoxley Hi, there. Thanks for your help! I tried battery_20 and battery_30 but they didn't appear, unfortunately.

It looks like I may have missed many icons from https://material.io/tools/icons because this site refers to https://storage.googleapis.com/non-spec-apps/mio-icons/latest/baseline.css to show its icons. I used https://fonts.googleapis.com/icon?family=Material+Icons instead to search.

I also tried increasing the search range outside of e000-efff, but this seemed to find normal Unicode characters.

I'm still looking for icon names for these 7 icons that, currently, we can only find using a codepoint:

icons with unknown icon names

@rayfoss This is my first PR. Can you explain to me what your PR process is like, and if there's something I need to do from my side? Thanks!

@FossPrime
Copy link

I'm just a regular user of this library... GitHub let's anyone review. It's about as meaningful as giving the PR a thumbs up because this bug is annoying.

@ijlee2
Copy link
Author

ijlee2 commented Jul 28, 2018

Ah, is that so. Yeah, I hope that the repo can be updated soon.

@wachunga wachunga mentioned this pull request Nov 15, 2018
@ijlee2 ijlee2 closed this Apr 8, 2020
@ijlee2 ijlee2 deleted the update-list-of-codepoints branch April 14, 2021 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants