Disallow scrolling if drawer is open (fixes #1348) #1652
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should the |
|
@Garbee Thanks! Good catch! Removed. |
|
Change here LGTM, but let's loop in @Zodiase to see if this addresses the issue adequately on their end too. |
|
Yep LGTM. Thanks. |
|
Change LGTM for a merge. Appreciate the double check, @Zodiase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pure CSS solution to this problem. To my surprise, switching from
overflow: scrolltooverflow: hiddenafter the page has been scrolled doesn’t make it jump back to the top but just locks it wherever it is at that moment.Put this file in your
distto test locally. Worked for me just fine though.