Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove XHTML slashes #1655

Merged
merged 2 commits into from
Oct 1, 2015
Merged

Remove XHTML slashes #1655

merged 2 commits into from
Oct 1, 2015

Conversation

surma
Copy link
Contributor

@surma surma commented Sep 28, 2015

As discussed in #1650 with @sindresorhus

@Garbee
Copy link
Collaborator

Garbee commented Sep 28, 2015

lgtm

@sindresorhus
Copy link
Contributor

There are more instances of XHTML slashes. Try grepping for "/>" ;)

@sindresorhus
Copy link
Contributor

Here's the places that needs fixing:

docs/_templates/layout.html
30:    <link rel="shortcut icon" href="{{page.include_prefix}}assets/favicon.png" />

src/checkbox/snippets/check-off.html
2:  <input type="checkbox" id="checkbox-2" class="mdl-checkbox__input" />

src/checkbox/snippets/check-on.html
2:  <input type="checkbox" id="checkbox-1" class="mdl-checkbox__input" checked />

src/icon-toggle/snippets/icon-off.html
2:  <input type="checkbox" id="icon-toggle-2" class="mdl-icon-toggle__input" />

src/icon-toggle/snippets/icon-on.html
2:  <input type="checkbox" id="icon-toggle-1" class="mdl-icon-toggle__input" checked />

src/layout/snippets/fixed-header-drawer.html
16:                 id="fixed-header-drawer-exp" />

src/layout/snippets/waterfall-header.html
23:                 id="waterfall-exp" />

src/radio/snippets/radio-off.html
2:  <input type="radio" id="option-2" class="mdl-radio__button" name="options" value="2" />

src/radio/snippets/radio-on.html
2:  <input type="radio" id="option-1" class="mdl-radio__button" name="options" value="1" checked />

src/slider/snippets/demo.html
4:        min="0" max="100" value="0" tabindex="0"/>
8:        min="0" max="100" value="10" tabindex="0"/>

src/slider/snippets/slider-default.html
3:  min="0" max="100" value="0" tabindex="0"/>

src/slider/snippets/slider-starting-value.html
3:  min="0" max="100" value="25" tabindex="0"/>

src/switch/snippets/switch-off.html
2:  <input type="checkbox" id="switch-2" class="mdl-switch__input" />

src/switch/snippets/switch-on.html
2:  <input type="checkbox" id="switch-1" class="mdl-switch__input" checked />

src/textfield/snippets/textfield-expanding.html
8:      <input class="mdl-textfield__input" type="text" id="sample6" />

src/textfield/snippets/textfield-floating-numeric.html
4:    <input class="mdl-textfield__input" type="text" pattern="-?[0-9]*(\.[0-9]+)?" id="sample4" />

src/textfield/snippets/textfield-floating-text.html
5:    <input class="mdl-textfield__input" type="text" id="sample3" />

src/textfield/snippets/textfield-numeric.html
4:    <input class="mdl-textfield__input" type="text" pattern="-?[0-9]*(\.[0-9]+)?" id="sample2" />

src/textfield/snippets/textfield-text.html
4:    <input class="mdl-textfield__input" type="text" id="sample1" />

test/index.html
9:  <link rel="stylesheet" href="../dist/material.css"/>

templates/article/index.html
40:    <link rel="shortcut icon" href="images/favicon.png" />
74:              <input class="mdl-textfield__input" type="text" id="search" />

templates/blog/index.html
40:    <link rel="shortcut icon" href="images/favicon.png" />

templates/dashboard/index.html
40:    <link rel="shortcut icon" href="images/favicon.png" />
74:              <input class="mdl-textfield__input" type="text" id="search" />
166:                      <input type="checkbox" id="chkbox1" class="mdl-checkbox__input" />
172:                      <input type="checkbox" id="chkbox2" class="mdl-checkbox__input" />
178:                      <input type="checkbox" id="chkbox3" class="mdl-checkbox__input" />
184:                      <input type="checkbox" id="chkbox4" class="mdl-checkbox__input" />

templates/android-dot-com/index.html
59:              <input class="mdl-textfield__input" type="text" id="search-field" />

templates/text-only/index.html
40:    <link rel="shortcut icon" href="images/favicon.png" />

@surma
Copy link
Contributor Author

surma commented Sep 28, 2015

Lol. My editor failed me. Thanks for keeping an eye out, @sindresorhus.

@sindresorhus
Copy link
Contributor

Would recommend https://github.com/ggreer/the_silver_searcher ;)

@surma
Copy link
Contributor Author

surma commented Sep 30, 2015

@sindresorhus It is done!

Local testing suggests everything remains functional.

@Garbee Pls Re-ACK, if you find the time.

@Garbee
Copy link
Collaborator

Garbee commented Sep 30, 2015

LGTM merge at will once drone passes.

@addyosmani
Copy link
Contributor

LGTM2. Drone appears to be passing here now.

addyosmani added a commit that referenced this pull request Oct 1, 2015
@addyosmani addyosmani merged commit 7cc4e3d into mdl-1.0 Oct 1, 2015
@addyosmani addyosmani deleted the non-xhtml branch October 1, 2015 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants