Buttons use only before psuedo #4628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| &:active::after { | ||
| &:active::before { | ||
| opacity: .06; |
There was a problem hiding this comment.
This is actually decreases the opacity, when what we really want is to increase it. I think you mean .18 here (.12 + another .06)
|
💎 LGTM besides that one comment. |
|
LGTM other than @traviskaufman's comment. |
|
Fixed the opacity issue. |
|
Once CI passes since everything else is un-changed I'll go ahead and merge. |
Let Tooltips have control over the after psuedo element so they will inter-operate with buttons.
|
So, PTAL again just to verify I'm not insane. I saw we had a duplicate selector fixing the linting issue so I compressed it. Shouldn't cause any problems but.... this is CSS. |
|
💎 You are, indeed, not insane :) LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make buttons use only the before pseudo. This allows tooltips to have
afterto themselves for them to inter-operate.