Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit test mdl-1.x #4833

Merged
merged 3 commits into from Oct 12, 2016
Merged

Fix unit test mdl-1.x #4833

merged 3 commits into from Oct 12, 2016

Conversation

ko22009
Copy link
Contributor

@ko22009 ko22009 commented Oct 7, 2016

In the browser failed tests, test/index.html

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@ko22009
Copy link
Contributor Author

ko22009 commented Oct 7, 2016

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Oct 7, 2016
@sgomes
Copy link
Contributor

sgomes commented Oct 12, 2016

LGTM, this seems to fix our tests. Thanks, @CodeGenTeam!

@sgomes sgomes merged commit 3b8b0d1 into google:mdl-1.x Oct 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants