fix a bug where oldNode was null on every step #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yeah, I think this would fix it. Thanks for figuring that out! I was trying to remember why the So instead of this change, can you just delete the
(or something like that) How's that sound? |
hmaurer
force-pushed
the
fix-null-oldNode
branch
from
690f871
to
cc10773
Compare
|
Should be good to merge! |
evykassirer
reviewed
Jan 22, 2017
| @@ -44,8 +44,8 @@ function stepThrough(node, debug=false) { | |||
| logSteps(nodeStatus); | |||
| } | |||
| steps.push(removeUnnecessaryParensInStep(nodeStatus)); | |||
| nodeStatus.reset(); | |||
| nodeStatus = step(nodeStatus.newNode); | |||
| const nextNode = Status.resetChangeGroups(nodeStatus.newNode); | |||
There was a problem hiding this comment.
merge your change to run tests+linter before committing ;D
you need to import Status here
There was a problem hiding this comment.
np :) lemme know when it's ready!
There was a problem hiding this comment.
Should be now! I had forgotten to push yesterday...
hmaurer
force-pushed
the
fix-null-oldNode
branch
from
cc10773
to
f6f1a40
Compare
arbylee
pushed a commit
to arbylee/mathsteps
that referenced
this pull request
Jul 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #77. As far as I could see there was no point setting
oldNodetonullinStatus.reset. The tests are still passing so I assume I didn't do something completely silly by removing it. Fingers crossed.