-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add KV Cache Layout Control and Attention Tests #667
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morgandu
assigned morgandu, rwitten, patemotter, yeandy and vipannalla and unassigned morgandu
May 23, 2024
vipannalla
reviewed
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, few comments. Also, the microbenchmark results looks great, were you able to do a full end-2-end on JetStream?
morgandu
force-pushed
the
mor--kv-cache-layout
branch
2 times, most recently
from
May 23, 2024 18:14
2c3ecf8
to
185563d
Compare
vipannalla
approved these changes
May 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
morgandu
changed the title
Add KV Cache Layout Control
[WIP] Add KV Cache Layout Control
May 24, 2024
morgandu
force-pushed
the
mor--kv-cache-layout
branch
2 times, most recently
from
May 30, 2024 05:34
58796a7
to
187cb3d
Compare
morgandu
changed the title
[WIP] Add KV Cache Layout Control
Add KV Cache Layout Control and Attention Tests
May 30, 2024
morgandu
force-pushed
the
mor--kv-cache-layout
branch
from
May 30, 2024 21:54
187cb3d
to
000e935
Compare
gobbleturk
approved these changes
May 31, 2024
morgandu
force-pushed
the
mor--kv-cache-layout
branch
2 times, most recently
from
May 31, 2024 19:16
58b5b31
to
4b4eaaa
Compare
morgandu
force-pushed
the
mor--kv-cache-layout
branch
from
June 3, 2024 05:06
4b4eaaa
to
57429da
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to enable KV Cache Layout Control to allow permutation experiments seeking performance improvement.
Checklist
Microbenchmark - Performance
Setup
Results
Summary
Before
Xprof: https://xprof.corp.google.com/overview_page/morgandu-14884055542603397573
After
Xprof: https://xprof.corp.google.com/overview_page/morgandu-16660388030961792706
NOTE:
E2E tests with JetStream v0.2.2 - Accuracy and Performance
Setup
Results
Summary
chat
and quant modew-b16-kv-i8
combination is the main mode of interest, as weight quantization is still dev in progressDetails