Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip extracting whitespace-only messages #111

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Conversation

mgeisler
Copy link
Collaborator

@mgeisler mgeisler commented Nov 5, 2023

This skips empty messages and messages consisting of whitespace only.

Fixes #64.

@mgeisler mgeisler requested a review from dyoo November 5, 2023 15:17
@mgeisler mgeisler force-pushed the skip-empty-messages branch 8 times, most recently from dd12327 to af19f55 Compare November 5, 2023 16:03
@mgeisler
Copy link
Collaborator Author

mgeisler commented Nov 6, 2023

With this, we can now extract messages from the Rust Book and the second commits implements a test for this!

i18n-helpers/src/lib.rs Outdated Show resolved Hide resolved
This skips empty messages and messages consisting of whitespace only.

Fixes #64.
This did not work before because we produced many duplicate `""`
messages.
@mgeisler mgeisler merged commit 469a25d into main Nov 8, 2023
6 checks passed
@mgeisler mgeisler deleted the skip-empty-messages branch November 8, 2023 07:51
This was referenced Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter out empty msgid entries
2 participants