Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define fuzzer for xgettext binary #128

Merged
merged 2 commits into from
Dec 22, 2023
Merged

Define fuzzer for xgettext binary #128

merged 2 commits into from
Dec 22, 2023

Conversation

kdarkhan
Copy link
Collaborator

@kdarkhan kdarkhan commented Dec 8, 2023 •
edited by mgeisler
Loading

This defines the last binary fuzzer as a part of #57.

Fixes #57.

@kdarkhan
Copy link
Collaborator Author

Ping @mgeisler, let me know if you have any comments on this PR.

mgeisler
mgeisler approved these changes Dec 22, 2023
View reviewed changes
Copy link
Collaborator

@mgeisler mgeisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! The summary_reader surprised me a little, but I get that it's there to avoid writing an unnecessary file to disk. An alternative would be to let create_catalog take a &str directly, but this seems nice too.

@mgeisler mgeisler merged commit dbe3b03 into google:main Dec 22, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgeisler mgeisler mgeisler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a fuzz tests for all binaries
2 participants
@kdarkhan @mgeisler