Upgrade codecov-action to v4 #179
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #179 +/- ##
=======================================
Coverage 90.58% 90.58%
=======================================
Files 12 12
Lines 3133 3133
Branches 3133 3133
=======================================
Hits 2838 2838
Misses 211 211
Partials 84 84 ☔ View full report in Codecov by Sentry. |
| @@ -95,7 +95,7 @@ jobs: | |||
| path: repo_root | |||
|
|
|||
| - name: Upload coverage to Codecov | |||
| uses: codecov/codecov-action@v3 | |||
| uses: codecov/codecov-action@v4 | |||
There was a problem hiding this comment.
Should this maybe be v4.1, if v4.0 has the bug?
There was a problem hiding this comment.
codecov-action maintainers seem to move v4 tag as they release new minor versions. v4 points to v4.1.0 according to this. I think it will be simpler to have it as v4 so we don't need to change when v4.2 is released.
There was a problem hiding this comment.
Should this maybe be
v4.1, ifv4.0has the bug?
Good question!
codecov-actionmaintainers seem to movev4tag as they release new minor versions.v4points tov4.1.0according to this.
Yes, this is the way tags for GitHub actions typically work: people move them around so that you get the latest semver-compatible version when you depend on a given tag. It's a bit silly, but that's the way things work last time I checked.
The GitHub documentation still recommends this: Using tags for release management.
With the issues codecov/feedback#263 and codecov/codecov-action#1287 resolved, we can upgrade to v4 again.
This fixes #173