Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary strip_link #203

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Conversation

dalance
Copy link
Contributor

@dalance dalance commented Jun 10, 2024

strip_link seems to remove all links from catalog.
According to the comment, it should be applied to summary only.

// The summary is mostly links like "[Foo *Bar*](foo-bar.md)".
// We strip away the link to get "Foo *Bar*". The formatting
// is stripped away by mdbook when it sends the book to
// mdbook-gettext -- we keep the formatting here in case the
// same text is used for the page title.

Closes #202

@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.51%. Comparing base (71b4cc5) to head (9440833).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #203      +/-   ##
==========================================
+ Coverage   89.50%   89.51%   +0.01%     
==========================================
  Files          13       13              
  Lines        3135     3138       +3     
  Branches     3135     3138       +3     
==========================================
+ Hits         2806     2809       +3     
  Misses        236      236              
  Partials       93       93              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dalance
Copy link
Contributor Author

dalance commented Jun 10, 2024

I added a link example to non-SUMMARY.md test to catch this case.

@kdarkhan kdarkhan merged commit 035c4a1 into google:main Jun 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link is not extracted at v0.3.3
3 participants