Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced Depricated tf.contrib.deprecated.scalar_summary with tf.compat.v1.summary.scalar #7

Merged
merged 3 commits into from Jul 27, 2019

Conversation

ashutosh1919
Copy link
Contributor

This is slight change in the Summary ProtoBuf. Initially the project writers have used deprecated method scalar_summary() of tf.contrib.deprecated. But since, It may be excluded in upcomming version of tensorflow. @roadjiang sir, please review this PR.
Thank you for this awesome project. It helped me very much in my work. This also tends to work with Conventional Deep Neural Nets with structured data.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

Copy link
Contributor

@roadjiang roadjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roadjiang
Copy link
Contributor

roadjiang commented Jul 25, 2019 via email

Copy link
Contributor

@roadjiang roadjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the instructions below. Thanks for the change.

If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@ashutosh1919
Copy link
Contributor Author

Thank you for merging @roadjiang . I had tried creating CLA for both email IDs associated with github account. But it has some problem.
Anyway, Thanks once again.

@ashutosh1919 ashutosh1919 deleted the comments branch May 20, 2021 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants