Enable --overriding-parameter-count-checks and fix related failures

google · Apr 26, 2023 · 75daca7 · 75daca7
1 parent 0f24e63
commit 75daca7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -38,7 +38,7 @@ jobs:
         task: [Typecheck, Lint, Yapf, Test]
         include:
           - task: Typecheck
-            cmd: pytype -j auto .
+            cmd: pytype -j auto --overriding-parameter-count-checks .
           - task: Lint
             cmd: pylint --rcfile .pylintrc --recursive yes .
           - task: Yapf

diff --git a/compiler_opt/rl/local_data_collector_test.py b/compiler_opt/rl/local_data_collector_test.py
@@ -89,7 +89,11 @@ def mock_collect_data(loaded_module_spec: corpus.LoadedModuleSpec, policy,
 class Sleeper(compilation_runner.CompilationRunner):
   """Test CompilationRunner that just sleeps."""
 
-  def collect_data(self, loaded_module_spec, policy, reward_stat, model_id):
+  def collect_data(self,
+                   loaded_module_spec,
+                   policy=None,
+                   reward_stat=None,
+                   model_id=None):
     _ = loaded_module_spec, policy, reward_stat
     compilation_runner.start_cancellable_process(['sleep', '3600s'], 3600,
                                                  self._cancellation_manager)