Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure data_collector.DEADLINE_IN_SECONDS is higher than compilation_runner.COMPILATION_TIMEOUT #232

Merged
merged 1 commit into from
May 9, 2023

Conversation

MatzeB
Copy link
Contributor

@MatzeB MatzeB commented May 9, 2023

This also removes the currently unused compilation_timeout parameter from the CompilationRunner constructor to avoid discrepancies.

…runner.COMPILATION_TIMEOUT

This also removes the currently unused `compilation_timeout` parameter
from the CompilationRunner constructor to avoid discrepancies.
@MatzeB MatzeB changed the title Ensure data_collector.DEADLINE_IN_SECONDS is higher than compilation_… Ensure data_collector.DEADLINE_IN_SECONDS is higher than compilation_runner.COMPILATION_TIMEOUT May 9, 2023
@mtrofin mtrofin merged commit 599880b into google:main May 9, 2023
15 checks passed
@MatzeB MatzeB deleted the set_deadline_based_on_timeout branch May 9, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants