-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump TFLite commit #293
Bump TFLite commit #293
Conversation
@mtrofin Maybe we want to setup CI for this somewhere? There have been multiple regressions between the TFLite version that we were at and this one related to dependencies. Catching them as they come up would probably be nice. This would probably be even more beneficial given that this TFLite build configuration doesn't seem particularly well supported. A decent amount of the patches seem to be coming from external contributors. |
This patch bumps the TFLite commit in build_tflite.sh and fixes associated fallout related to TFLite dependencies and build configurations changing.
9149e99
to
fdf59e6
Compare
Looks like this needs more work than expected. The CMake install within Tensorflow for TFLite doesn't output a From the LLVM build:
Running ls /tflite/tensorflow/include/tensorflow/lite/core/async/ gives
with no interop directory, but ls /tflite/tensorflow/src/tensorflow/tensorflow/lite/core/async/interop/c/ shows
|
This should be ready once tensorflow/tensorflow#61767 and tensorflow/tensorflow#61768 land. |
You mean a CI along the tensorflow repo. Yea, we should. I have one for the AOT scenario already using internal infra, this would be complementary. Could do it public, too, but not sure if there are triggers I could use for that. |
reverting because tensorflow/tensorflow#61767 didn't actually land |
This patch relands 49e5d32, bumping the TFLite version after that commit was mistakenly landed without waiting for some upstream patches in Tensorflow land first.
This reverts commit 84efbae.
This patch bumps the TFLite commit in build_tflite.sh and fixes associated fallout related to TFLite dependencies and build configurations changing.
After about 2.5 hours of debugging...
Fixes #292