Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove corpus extraction tooling #334

Merged

Conversation

boomanaiden154
Copy link
Collaborator

Now that the corpus extraction tooling has been moved into the LLVM monorepo, we can remove it from within ml-compiler-opt. This patch does the mechanical removal and updates the demos to refer to installing the upstream tooling so they are still functional.

Now that the corpus extraction tooling has been moved into the LLVM
monorepo, we can remove it from within ml-compiler-opt. This patch does
the mechanical removal and updates the demos to refer to installing the
upstream tooling so they are still functional.
@boomanaiden154
Copy link
Collaborator Author

I'm currently just putting manual installation steps in the demo. I'm planning on adding mlgo-utils to the MLGO dependencies once we get around to regenerating the lockfile (been putting this off for quite a while now), but I want to do that all at once for several reasons:

  1. Now that the LLVM monorepo is the canonical source for the corpus extraction tooling, it wouldn't be good to refer to the old tooling here.
  2. There are other downstream consumers that are impacted by the changing of the lockfile that I'd rather not have blocking this change.
  3. There are some other issues that need to be cleaned up that come along with some packages being bumped that I haven't gotten around to figuring out yet.

Copy link
Collaborator

@mtrofin mtrofin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, ready to be merged once we start producing the pip package

@boomanaiden154
Copy link
Collaborator Author

lgtm, ready to be merged once we start producing the pip package

I already pushed the pip package once to reserve the name (https://pypi.org/project/mlgo-utils/), and the name won't be changing, so this should be good to go.

@boomanaiden154 boomanaiden154 merged commit 7a62027 into google:main Jan 21, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants