Modernise the build #158
Closed
Modernise the build #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm testing out these changes. Specifically I worry about some of the deprecated code and bumping the targetSdk. |
|
Any update on the last comment? |
|
I haven't observed any, but have only used 2 or 3 of the snippets. Is it worth us adding some instrumentation tests, potentially against FTL or emulators? They could run without mobly, just calling the snippets. |
This was referenced Mar 8, 2023
|
@ko1in1u let's see if we can update all the build files except the SDK ver for now |
|
MBS has been modernised in PR#166. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried following the instructions, but after opening in Android Studio I got a bunch of errors.
But also jcenter is down. So this was not building.
Happy to take guidance on what to fix.
This change is