Show test run metadata in test summary. #751
Conversation
* Encapsulate test run metadata with a proper container. * Record test run elapsed time. * Print out the log path to make parsing easier.
* Encapsulate test run metadata with a proper container. * Record test run elapsed time. * Print out the log path to make parsing easier.
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 4 unresolved discussions (waiting on @xpconanfan)
mobly/test_runner.py, line 186 at r1 (raw file):
self.results
this should be results
mobly/test_runner.py, line 303 at r1 (raw file):
Refersh
typo: Refresh
mobly/test_runner.py, line 415 at r1 (raw file):
f'Artifacts are saved in "{self._test_run_metadata.root_output_path}"',
I am just wondering do we want to just print this information once?
Now, the first and the last line of the test_log.INFO show the same info:
https://gist.github.com/eric100lin/d6592a5d00e1053a2ab3b2e1636d49c6#file-test_log-info
mobly/test_runner.py, line 419 at r1 (raw file):
msg = '\n'.join(summary_lines) logging.info(msg.strip())
I think we don't need strip anymore.
How about just inline it: logging.info('\n'.join(summary_lines))
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 4 unresolved discussions (waiting on @eric100lin and @xpconanfan)
mobly/test_runner.py, line 186 at r1 (raw file):
Previously, eric100lin (Eric Lin (Tzu Hsiang Lin)) wrote…
self.resultsthis should be
results
Done.
mobly/test_runner.py, line 303 at r1 (raw file):
Previously, eric100lin (Eric Lin (Tzu Hsiang Lin)) wrote…
Refershtypo: Refresh
Done.
mobly/test_runner.py, line 415 at r1 (raw file):
Previously, eric100lin (Eric Lin (Tzu Hsiang Lin)) wrote…
f'Artifacts are saved in "{self._test_run_metadata.root_output_path}"',I am just wondering do we want to just print this information once?
Now, the first and the last line of the test_log.INFO show the same info:
https://gist.github.com/eric100lin/d6592a5d00e1053a2ab3b2e1636d49c6#file-test_log-info
The one at the beginning is from the logger module.
Changed that to DEBUG level
mobly/test_runner.py, line 419 at r1 (raw file):
Previously, eric100lin (Eric Lin (Tzu Hsiang Lin)) wrote…
msg = '\n'.join(summary_lines) logging.info(msg.strip())I think we don't need
stripanymore.
How about just inline it:logging.info('\n'.join(summary_lines))
Done.
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @xpconanfan)
* Encapsulate test run metadata with a proper container. * Record test run elapsed time. * Print out the log path to make parsing easier. * Clarify the ambiguity in test runner logger setup and run.
This change is