-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not start logcat service when the Andriod device is in fastboot mode. #881
Conversation
Adding a property in `AndroidDevice` to check if it's in fastboot mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @xpconanfan)
mobly/controllers/android_device.py
line 878 at r1 (raw file):
@property def is_fastboot(self):
Looks like this is the same as the property is_bootloader
?
And if this is needed, adding the docstring?
Code quote:
is_fastboot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @mhaoli and @xpconanfan)
mobly/controllers/android_device.py
line 878 at r1 (raw file):
Previously, mhaoli (Minghao Li) wrote…
Looks like this is the same as the property
is_bootloader
?And if this is needed, adding the docstring?
Ah yes. Nice catch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @mhaoli and @xpconanfan)
mobly/controllers/android_device.py
line 878 at r1 (raw file):
Previously, xpconanfan (Ang Li) wrote…
Ah yes. Nice catch.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 4 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @xpconanfan)
Also adding a property in
AndroidDevice
to check if it's in fastboot mode.This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)