Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not start logcat service when the Andriod device is in fastboot mode. #881

Merged
merged 3 commits into from
Apr 25, 2023

Conversation

xpconanfan
Copy link
Collaborator

@xpconanfan xpconanfan commented Apr 19, 2023

Also adding a property in AndroidDevice to check if it's in fastboot mode.


This change is Reviewable

Adding a property in `AndroidDevice` to check if it's in fastboot mode.
Copy link
Collaborator

@mhaoli mhaoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @xpconanfan)


mobly/controllers/android_device.py line 878 at r1 (raw file):

  @property
  def is_fastboot(self):

Looks like this is the same as the property is_bootloader?

And if this is needed, adding the docstring?

Code quote:

is_fastboot

Copy link
Collaborator Author

@xpconanfan xpconanfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @mhaoli and @xpconanfan)


mobly/controllers/android_device.py line 878 at r1 (raw file):

Previously, mhaoli (Minghao Li) wrote…

Looks like this is the same as the property is_bootloader?

And if this is needed, adding the docstring?

Ah yes. Nice catch.

Copy link
Collaborator Author

@xpconanfan xpconanfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @mhaoli and @xpconanfan)


mobly/controllers/android_device.py line 878 at r1 (raw file):

Previously, xpconanfan (Ang Li) wrote…

Ah yes. Nice catch.

Done.

Copy link
Collaborator

@mhaoli mhaoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 4 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @xpconanfan)

@xpconanfan xpconanfan merged commit 031aa94 into master Apr 25, 2023
@xpconanfan xpconanfan deleted the fastboot branch April 25, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants