New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifying user id for snippet client. #898

Closed

nkprasad12 wants to merge 1 commit into google:master from nkprasad12:addAccount

Contributor

nkprasad12 commented Oct 23, 2023 •

edited by xpconanfan

Loading

This change is


          Allow specifying user id for snippet client.

cccd5ab

Collaborator

xpconanfan commented Oct 23, 2023

Could we not do the formatting?
It's difficult to review

Contributor Author

nkprasad12 commented Oct 23, 2023

Sure.

Let's remove the relevant section from https://github.com/google/mobly/blob/master/CONTRIBUTING.md#code-style then?

Collaborator

xpconanfan commented Oct 23, 2023

We should do dedicated formatting PRs to catch up...

Collaborator

xpconanfan commented Oct 23, 2023

Also presubmit is failing which blocks merging

nkprasad12 closed this

nkprasad12 deleted the addAccount branch

October 23, 2023 06:11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment