-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix current formatting issues and add formatting check to CI workflow #902
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 17 files reviewed, 1 unresolved discussion (waiting on @mhaoli and @xpconanfan)
.github/workflows/ci.yml
line 32 at r1 (raw file):
Previously, mhaoli (Minghao Li) wrote…
Oh I see your comment, great!
Would you like to:
- Align with Google internal Python formatter
go/pyformat#pyink
Since Feb 2, 2023, we have switched Pyformat from using YAPF to Pyink for all of google3 by default.
Pyink is open sourced: https://github.com/google/pyink - Git hook scripts run on every commit to automatically point out issues in code
Reference: https://pre-commit.com/
Reference:
google/snippet-uiautomator@966bdd8
Switching to pyink would make some sense to me, WDYT @xpconanfan |
If this means our code would be formatted the exact same way as internal py
code, sure.
…On Wed, Oct 25, 2023, 08:42 nkprasad12 ***@***.***> wrote:
*Reviewable <https://reviewable.io/reviews/google/mobly/902>* status: 0
of 17 files reviewed, 1 unresolved discussion (waiting on @mhaoli
<https://github.com/mhaoli> and @xpconanfan
<https://github.com/xpconanfan>)
*.github/workflows/ci.yml line 32 at r1
<https://reviewable.io/reviews/google/mobly/902#gh-1371347695:-Nh_zl5u6NzGnyQ_yt_s:bt8u4zm>
(raw file
<https://github.com/google/mobly/blob/5a25d67796bd48a2df4f3eaadfbe25afa5101178/.github/workflows/ci.yml#L32>):*
Previously, mhaoli (Minghao Li) wrote…
Would you like to:
1. Align with Google internal Python formatter
go/pyformat#pyink
Since Feb 2, 2023, we have switched Pyformat from using YAPF to Pyink
for all of google3 by default.
Pyink is open sourced: https://github.com/google/pyink
2. Git hook scripts run on every commit to automatically point out
issues in code
Reference: https://pre-commit.com/
Reference: ***@***.***
<google/snippet-uiautomator@966bdd8>
Switching to pyink would make some sense to me, WDYT @xpconanfan
<https://github.com/xpconanfan>
—
Reply to this email directly, view it on GitHub
<#902 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARDNZL4WGBUOFPUPDQERNTYBEXORAVCNFSM6AAAAAA6OCIARKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZZGU3DGMRZGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Switched to |
…google#902) * Switch to Pyink for formatting --------- Co-authored-by: Nitin Prasad <nkprasad@google.com>
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)