Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into removing the resize observer #2

Closed
smalls opened this issue Oct 18, 2018 · 2 comments
Closed

Look into removing the resize observer #2

smalls opened this issue Oct 18, 2018 · 2 comments
Assignees

Comments

@smalls
Copy link
Contributor

smalls commented Oct 18, 2018

We may be able to check the size of the element every frame instead.

@smalls smalls added this to To do in model-viewer Oct 18, 2018
@cdata cdata self-assigned this Oct 19, 2018
@cdata cdata moved this from To do to In progress in model-viewer Oct 19, 2018
@jsantell
Copy link
Contributor

The resize-observer polyfill polls with getBoundingClientRect, and resize-observer-polyfill uses a global mutation observer watching everything. I think maybe the sync reflow option might be preferable since we don't know what else will be on the page. This is an interesting solution as well

@jsantell
Copy link
Contributor

Also, the resize observer is chrome only for the most part

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
model-viewer
  
Done
Development

No branches or pull requests

3 participants