Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lit dependency to 3.1 #4678

Closed
jcoyne opened this issue Feb 14, 2024 · 6 comments
Closed

Update lit dependency to 3.1 #4678

jcoyne opened this issue Feb 14, 2024 · 6 comments

Comments

@jcoyne
Copy link

jcoyne commented Feb 14, 2024

No description provided.

@elalish
Copy link
Collaborator

elalish commented Feb 14, 2024

Planning to send a PR? Would also be nice to know what this unblocks, though I agree that staying up-to-date with dependencies is a good idea.

@jcoyne
Copy link
Author

jcoyne commented Feb 14, 2024

I'm not planning on sending a PR. I just wanted to track this issue. I'm most concerned with https://github.com/lit/lit/pull/2103/files#diff-9204efca403aca3ce114a362b26ecd70d56cc7f3e093f895c9cfc2bd2b4f4800 which allows lit to be used via importmap on a CDN.

@elalish
Copy link
Collaborator

elalish commented Feb 14, 2024

Does that issue flow down to MV? I believe MV works via importmap on a CDN currently.

@jcoyne
Copy link
Author

jcoyne commented Feb 14, 2024

I might be a bit confused about this matter. On this page https://modelviewer.dev/examples/postprocessing/ I see an importmap is used for three, but not for lit. My assumption was that lit needs to be in the importmap as well since it is a dependency in https://github.com/google/model-viewer/blob/master/packages/model-viewer/package.json#L86C6-L86C9

@elalish
Copy link
Collaborator

elalish commented Feb 14, 2024

No, we generally bundle all of our dependencies so that no import maps are needed. For the special case of the optional postprocessing feature, we split it into three: model-viewer-module, model-viewer-effects, and the standard three.js library which they both depend on. Lit is still bundled (it's tiny).

@jcoyne
Copy link
Author

jcoyne commented Feb 15, 2024

Oh, cool! Thanks for explaining it to me.

@jcoyne jcoyne closed this as completed Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants