dispose material textures when disposing GLTFInstance #2600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elalish
approved these changes
Jul 21, 2021
| for (const propertyName in material) { | ||
| const propertyValue = (material as any)[propertyName]; | ||
| if (propertyValue instanceof Texture) { | ||
| propertyValue.dispose(); |
There was a problem hiding this comment.
Good call! Not sure how we went this long without noticing our textures needed disposal. Did you verify this fixes the leak?
There was a problem hiding this comment.
Yes, the example I supplied in #2139 doesn't create memory overflow when tested on my local build with proposed fix.
ghost
approved these changes
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves problem with memory overflow when GLTFInstance object is being repeatedly created and disposed.
Reference Issue
Fixes: #2139